Improve handling of c++ attrs #1768
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
force-pushed
the
improveattrs
branch
3 times, most recently
from
5280808
to
010fa03
Compare
wsmoses
force-pushed
the
improveattrs
branch
from
010fa03
to
570934b
Compare
tgymnich
reviewed
Mar 4, 2024
Comment on lines
+408
to
+409
| changed = true; | ||
| changed |= preserveLinkage(Begin, F); |
Comment on lines
+383
to
+384
| // as first field, and the annotation as second field | ||
| if (ConstantStruct *CS = dyn_cast<ConstantStruct>(CAOp)) { |
There was a problem hiding this comment.
Can we reduce the indentation level here with something like this
ConstantStruct *CS = dyn_cast<ConstantStruct>(CAOp
if (!CS)
continue;
same for the following lines.
|
superceeded by upstream |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now should work with templates