[mlir] Define generic set/map lattices for dataflow analyses #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgymnich
reviewed
Mar 4, 2024
wsmoses
approved these changes
Mar 7, 2024
ftynse
approved these changes
Mar 7, 2024
pengmai
force-pushed
the
jmp/generic-lattices
branch
4 times, most recently
from
c058a5a
to
bb4dfc0
Compare
Add LLVM_DUMP_METHOD so that this method does not get stripped for debug builds Co-authored-by: Tim Gymnich <tgymnich@icloud.com>
pengmai
force-pushed
the
jmp/generic-lattices
branch
from
bb4dfc0
to
a929178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, the conceptual
AliasClassSet,AliasClassLattice, andPointsToSetsdata structures were immensely useful in implementing activity annotations. The "lattice of sets that might be undefined or unknown" and "map of attributes to those sets" are exactly the kind of data structures that activity annotations uses to propagate these relative "origins" both forward and backward, in an intraprocedural analysis.This PR aims to be an intermediate step towards merging in activity annotations by breaking out the re-usable logic into abstract classes.