Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLIR enable vararg activity #1781

Merged
merged 1 commit into from
Mar 6, 2024
Merged

MLIR enable vararg activity #1781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion enzyme/Enzyme/MLIR/Implementations/CoreDialectsAutoDiffImplementations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,8 @@ LogicalResult mlir::enzyme::detail::memoryIdentityForwardHandler(
} else {
if (gutils->isConstantValue(operand.get())) {

if (contains(storedVals, operand.getOperandNumber())) {
if (contains(storedVals, operand.getOperandNumber()) ||
contains(storedVals, -1)) {
if (auto iface =
dyn_cast<AutoDiffTypeInterface>(operand.get().getType())) {
if (!iface.isMutable()) {
Expand Down
29 changes: 19 additions & 10 deletions enzyme/Enzyme/MLIR/Passes/PrintActivityAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,22 @@ using namespace mlir;
namespace {
using llvm::errs;

enzyme::Activity getDefaultActivity(Type argType) {
if (argType.isIntOrIndex())
return enzyme::Activity::enzyme_const;

if (isa<FloatType, ComplexType>(argType))
return enzyme::Activity::enzyme_out;

if (auto T = dyn_cast<TensorType>(argType))
return getDefaultActivity(T.getElementType());

if (isa<LLVM::LLVMPointerType, MemRefType>(argType))
return enzyme::Activity::enzyme_dup;

return enzyme::Activity::enzyme_const;
}

struct PrintActivityAnalysisPass
: public enzyme::PrintActivityAnalysisPassBase<PrintActivityAnalysisPass> {

Expand All @@ -43,25 +59,18 @@ struct PrintActivityAnalysisPass
MutableArrayRef<enzyme::Activity> resActivities) const {
for (const auto &[idx, argType] :
llvm::enumerate(callee.getArgumentTypes())) {
if (callee.getArgAttr(idx, "enzyme.const") || inactiveArgs ||
argType.isIntOrIndex())
if (callee.getArgAttr(idx, "enzyme.const") || inactiveArgs)
argActivities[idx] = enzyme::Activity::enzyme_const;
else if (isa<FloatType, ComplexType>(argType))
argActivities[idx] = enzyme::Activity::enzyme_out;
else if (isa<LLVM::LLVMPointerType, MemRefType>(argType))
argActivities[idx] = enzyme::Activity::enzyme_dup;
else
argActivities[idx] = enzyme::Activity::enzyme_const;
argActivities[idx] = getDefaultActivity(argType);
}

for (const auto &[idx, resType] :
llvm::enumerate(callee.getResultTypes())) {
if (duplicatedRet)
resActivities[idx] = (enzyme::Activity::enzyme_dup);
else if (isa<FloatType>(resType))
resActivities[idx] = (enzyme::Activity::enzyme_out);
else
resActivities[idx] = (enzyme::Activity::enzyme_const);
resActivities[idx] = getDefaultActivity(resType);
}
}

Expand Down
8 changes: 8 additions & 0 deletions enzyme/tools/enzyme-tblgen/enzyme-tblgen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2050,9 +2050,17 @@ static void emitDerivatives(const RecordKeeper &recordKeeper, raw_ostream &os,
os << " };\n";
os << " bool isArgInactive(mlir::Operation*, size_t idx) const {\n";
for (auto diffarg : diffargs) {
if (diffarg == -1) {
os << " return false;\n";
break;
}
os << " if (idx == " << diffarg << ") return false;\n";
}
for (auto diffarg : storedargs) {
if (diffarg == -1) {
os << " return false;\n";
break;
}
os << " if (idx == " << diffarg << ") return false;\n";
}
os << " return true;\n }\n";
Expand Down
Loading