Fix clang compilation (failing since 0.0.150) #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the v0.0.150, it is not possible to compile Enzyme with clang. The source of the issue is a loop over references (local binding) that contains a lambda function. https://github.com/EnzymeAD/Enzyme/pull/2079/files#diff-ab7735609ebf1b75b3d6baedc231689532dff0a7a8e4e1838c3aed11c99795e5R3111
Clang refuses to compile it because local binding are not variables and cannot be captured by the lambda function. Solution here is to create a variable that can be then captured by the lambda function.
https://stackoverflow.com/questions/50799719/reference-to-local-binding-declared-in-enclosing-function?noredirect=1&lq=1