Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move Helpers to Eppie.App.Shared #365

Merged
merged 1 commit into from
Oct 2, 2024
Merged

chore: move Helpers to Eppie.App.Shared #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions source/Eppie.App/Eppie.App.Shared/Eppie.App.Shared.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<Compile Include="$(MSBuildThisFileDirectory)Authorization\AuthConfig.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Authorization\AuthConfig.UWP.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Authorization\WindowsAuthenticationBroker.UWP.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Helpers\BitmapTools.cs" />
<Compile Include="$(MSBuildThisFileDirectory)IncrementalLoading\IncrementalLoadingCollection.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Common\UITools.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Tools\ElementHierarchyTools.cs" />
Expand Down
10 changes: 5 additions & 5 deletions ...p/Eppie.App.Shared/Helpers/BitmapTools.cs → ...p/Eppie.App.Shared/Helpers/BitmapTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Threading.Tasks;
using Windows.Graphics.Imaging;
using Windows.Storage;
Expand All @@ -18,9 +18,9 @@
{
using (var imageStream = await sourceFile.OpenReadAsync())
{
var decoder = await BitmapDecoder.CreateAsync(imageStream);
var decoder = await BitmapDecoder.CreateAsync(imageStream); // ToDo: warning Uno0001: Windows.Graphics.Imaging.BitmapDecoder.*

Check warning on line 21 in source/Eppie.App/Eppie.App.Shared/Helpers/BitmapTools.cs

View workflow job for this annotation

GitHub Actions / windows-latest './source/Eppie.App/Eppie.App/Eppie.App.csproj' 

Windows.Graphics.Imaging.BitmapDecoder.CreateAsync(Windows.Storage.Streams.IRandomAccessStream) is not implemented in Uno (https://aka.platform.uno/notimplemented?m=Windows.Graphics.Imaging.BitmapDecoder.CreateAsync(Windows.Storage.Streams.IRandomAccessStream)) (https://aka.platform.uno/notimplemented)

var originalPixelWidth = decoder.PixelWidth;

Check warning on line 23 in source/Eppie.App/Eppie.App.Shared/Helpers/BitmapTools.cs

View workflow job for this annotation

GitHub Actions / windows-latest './source/Eppie.App/Eppie.App/Eppie.App.csproj' 

Windows.Graphics.Imaging.BitmapDecoder.PixelWidth is not implemented in Uno (https://aka.platform.uno/notimplemented?m=Windows.Graphics.Imaging.BitmapDecoder.PixelWidth) (https://aka.platform.uno/notimplemented)
var originalPixelHeight = decoder.PixelHeight;

if (originalPixelWidth > 0 && originalPixelHeight > 0)
Expand Down Expand Up @@ -72,10 +72,10 @@
private static async Task<byte[]> GetPixelDataAsync(BitmapDecoder decoder, uint startPointX, uint startPointY,
uint width, uint height, uint scaledWidth, uint scaledHeight)
{
var transform = new BitmapTransform();
var transform = new BitmapTransform(); // ToDo: warning Uno0001: Windows.Graphics.Imaging.BitmapTransform.*
transform.InterpolationMode = BitmapInterpolationMode.Linear;

var bounds = new BitmapBounds();
var bounds = new BitmapBounds(); // ToDo: warning Uno0001: Windows.Graphics.Imaging.BitmapBounds.*
bounds.X = startPointX;
bounds.Y = startPointY;
bounds.Height = height;
Expand All @@ -92,7 +92,7 @@
transform,
ExifOrientationMode.IgnoreExifOrientation,
ColorManagementMode.ColorManageToSRgb);
var pixels = pix.DetachPixelData();
var pixels = pix.DetachPixelData(); // ToDo: warning Uno0001: Windows.Graphics.Imaging.PixelDataProvider.DetachPixelData()
return pixels;
}
}
Expand Down
Loading