Add OpenWebRTCLocalAudioSource with volume property #58
Conversation
…s to OpenWebRTC-SDK/ so system includes work properly, add Foundation imports.
| // | ||
| // OpenWebRTCLocalAudioSource.h | ||
| // | ||
| // Copyright (c) 2016, Ericsson AB. |
There was a problem hiding this comment.
The Copyright should be yours since it is your change :)
There was a problem hiding this comment.
Oh.. I thought these sorts of contributions usually involved copyright
reassignment.
On Thu, Feb 18, 2016 at 11:24 PM, Stefan Ålund notifications@github.com
wrote:
In OpenWebRTC-SDK/OpenWebRTCLocalAudioSource.h
#58 (comment)
:@@ -0,0 +1,44 @@
+//
+// OpenWebRTCLocalAudioSource.h
+//
+// Copyright (c) 2016, Ericsson AB.The Copyright should be yours since it is your change :)
—
Reply to this email directly or view it on GitHub
https://github.com/EricssonResearch/openwebrtc-ios-sdk/pull/58/files#r53429820
.
There was a problem hiding this comment.
I don't think so, no. Your code, your copyright. @superdump what do you think?
There was a problem hiding this comment.
Come to think of it, the reason some projects do that so they're able to
change the license down the line if they need to, say if it turns out the
license wording needs to be updated for some reason. Without copyright
reassignment you'd need to get permission from each author rather than
simply changing the license unilaterally. I shouldn't have said "usually".
Some projects do it.
On Thu, Feb 18, 2016 at 11:28 PM, Stefan Ålund notifications@github.com
wrote:
In OpenWebRTC-SDK/OpenWebRTCLocalAudioSource.h
#58 (comment)
:@@ -0,0 +1,44 @@
+//
+// OpenWebRTCLocalAudioSource.h
+//
+// Copyright (c) 2016, Ericsson AB.I don't think so, no. Your code, your copyright. @superdump
https://github.com/superdump what do you think?—
Reply to this email directly or view it on GitHub
https://github.com/EricssonResearch/openwebrtc-ios-sdk/pull/58/files#r53430044
.
|
Please update the Copyright to your own. Other than that: 👍 |
|
@adrianbg could you please add your copyright header and also rebase? After that we can merge this one. |
For #55
Also move source files to OpenWebRTC-SDK/ so system includes work properly when imported straight from the repository.
Add Foundation imports. These were necessary to compile for me.