Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Refactor quicksort implementation #2

Merged
merged 5 commits into from
Nov 12, 2023
Merged

refactor: Refactor quicksort implementation #2

merged 5 commits into from
Nov 12, 2023

Conversation

Michael-Liendo
Copy link
Contributor

@Michael-Liendo Michael-Liendo commented Nov 12, 2023 •
edited
Loading

  • Allow repeat items

@Michael-Liendo Michael-Liendo marked this pull request as ready for review November 12, 2023 08:05
EstebanBorai
EstebanBorai reviewed Nov 12, 2023
View reviewed changes
Copy link
Owner

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!
Can we have a test with duplicated items?

@Michael-Liendo
Copy link
Contributor Author

Yeah

EstebanBorai
EstebanBorai approved these changes Nov 12, 2023
View reviewed changes
Copy link
Owner

@EstebanBorai EstebanBorai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EstebanBorai EstebanBorai merged commit 58419c6 into EstebanBorai:main Nov 12, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EstebanBorai EstebanBorai EstebanBorai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michael-Liendo @EstebanBorai