Add support for channel 2 of AdqDigitizer's #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace np.warnings with the warnings module - Replace np.float with float - Pass enum values instead of the enums themselves to redis functions - Drop support for saving float arrays PNG images and expecting them to be restored with the same values. Seems that Pillow dropped support for it.
|
LGTM, thanks. I haven't totally understood the hget related changes, but they look safe enough; I presume something changed with a new version of the redis client library. |
bermudei
approved these changes
Sep 18, 2023
Yeah, so we're passing enums to the function and those used to be automagically converted to integers, but now it doesn't do that anymore so we have to call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also sneaked in 6d91168 to fix the tests 🤭