-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Make 404 pages support multiple languages, and increase the length of the article summary #417
Conversation
This reverts commit c0dfbf2.
This reverts commit 647b28c.
This reverts commit dfe5920.
…ength of the article summary Previously, 404 pages were only in Chinese, but now translation has been added to make them support all languages of the topic Before, the article summary was very small, resulting in very little information, now increased to 300, the content will be more rich
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes involve the addition of a new localization key for "Go Back Home" in multiple language files, enhancing the application's multilingual support. Additionally, the 404 error page template has been updated to improve navigation options, and the truncation length for post content in the home content template has been increased from 128 to 300 characters, allowing for more content visibility. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant HomePage
participant PostContent
User->>HomePage: Visit Home
HomePage->>PostContent: Display Posts
PostContent->>User: Show Post Preview (300 characters)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- languages/en.yml (1 hunks)
- languages/ja.yml (1 hunks)
- languages/zh-CN.yml (1 hunks)
- languages/zh-TW.yml (1 hunks)
- layout/_partials/404-template.ejs (1 hunks)
- layout/_partials/home-content.ejs (1 hunks)
Files skipped from review due to trivial changes (4)
- languages/en.yml
- languages/ja.yml
- languages/zh-CN.yml
- languages/zh-TW.yml
Additional comments not posted (3)
layout/_partials/404-template.ejs (2)
6-7
: LGTM!The change improves user navigation by allowing users to return to the previous page instead of always going back to the homepage.
The code changes are approved.
9-13
: LGTM!The change provides an additional navigation option for users, improving the overall user experience on the 404 page.
The code changes are approved.
layout/_partials/home-content.ejs (1)
46-46
: LGTM!The change allows for a longer preview of the post content, providing users with more context before they decide to read the full article.
The code changes are approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the code here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code will not run correctly as the git conflict is not solved
This reverts commit 66d3a09.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use __("go-back-home")
helper function in order to correctly display i18n title
OK |
and how can i do |
Previously, 404 pages were only in Chinese, but now translation has been added to make them support all languages of the topic
Before, the article summary was very small, resulting in very little information, now increased to 300, the content will be more rich
Summary by CodeRabbit
New Features
Bug Fixes