-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the title format to include the subtitle. #427
Conversation
把副标题包含在了 title 里
WalkthroughWalkthroughThe changes include the addition of a site subtitle in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
@coderabbitai review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- _config.yml (1 hunks)
- layout/_partials/head.ejs (1 hunks)
Files skipped from review due to trivial changes (1)
- _config.yml
Additional comments not posted (2)
layout/_partials/head.ejs (2)
74-75
: LGTM!The code changes are approved. The pipe separator is being appended to the title when it is present, which is a valid change.
76-77
: LGTM!The code changes are approved. The subtitle is being appended to the title with a hyphen separator when it is available in the theme configuration. This change aligns with the PR objective of including the subtitle in the title format.
Thanks for the PR. I've noticed an issue with the title logic: When both <title>My Page Title | My Theme Title - Subtitle My Theme Title</title> Due to these issues, I won’t be merging this PR. Please address these concerns and feel free to resubmit when ready. |
Main page:
{sitetitle} - {subtitle}
Other page:
{pagetitle} | {sitetitle}
It was supposed to be written in the theme configuration that the user can choose which one to use, but I haven't done it yet.
Summary by CodeRabbit