feat: typescript implementation #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my name is Pontus Karlsson. I am making this PR with my TypeScript version of the Toll Calculator just in case we have a chat in the future 🙂 .
I have made very little assumptions about the intent behind the logic. In a real work situation I would have requested to have requirements such as which times of the day are toll free written in plain text, to make sure there are no bugs in the old implementation. However, I've chosen to lean on the side of caution and make sure that the code functions as before when it comes to those conditions. Though my version of the code is refactored for maintainability and hopefully less buggy.