Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roy from Orientalent. #95

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Roy from Orientalent. #95

wants to merge 5 commits into from

Conversation

royqiu2022
Copy link

  1. Add pom.xml to add log and and unit test dependences.
  2. Refactor multiple if statements for enum judgment.
  3. Refactor hard code for car type.
  4. Refactor multiple if statements for fee judgment, add a map to store the date range and corresponding fee,if the date passed in is under a date range, then give back the related fee.
  5. Refactor the holiday logic, remove multiple if statement, put all of holidays to a List.
  6. Simply the logic to count the fee for one hour period.
  7. Add factory to generate the free toll fee cars instance by enum TollFreeVehicles.
  8. Add all of test cases.
  9. Add log.
  10. the applications should not be only handle date for 2013, remove it.
  11. Add a class to generate the holiday for year, base on url:
    https://date.nager.at/PublicHoliday/Country/SE/2020
  12. update time and fee mapping to config file.

@royqiu2022
0. Add pom.xml to add log and and unit test dependences.
ea2f6e3 
1. Refactor multiple if statements for enum judgment.
2. Refactor hard code for car type.
3. Refactor multiple if statements for fee judgment, add a map to store the date range and corresponding fee,if the date passed in is under a date range, then give back the related fee.
4. Refactor the holiday logic, remove multiple if statement, put all of holidays to a List, if the date passed in is one of date in this List, means it is a holiday.
5. Simply the logic to count the fee for one hour period.
6. Add factory to generate the free toll fee cars instance by enum TollFreeVehicles.
7. Add all of test cases.
8. Add log.
9. the applications should not be only handle date for 2013, if the year changed, just update the holiday List.
10. Next step, can update holiday List and fee setting to config file. if any requirement changed or year changed,we just need to update the confige file.
@royqiu2022
Update a file package.
e8845d8
@royqiu2022
1. Generate the holiday for year.
06c766f 
2. update time and fee mapping to config file.
3. Add a class to handle date
@royqiu2022
Remvoe July from public holiday.
914588f
@royqiu2022
Add July for free.
dadaf92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@royqiu2022