Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Header row configuration option #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhill0
Copy link

@jhill0 jhill0 commented Oct 11, 2017

This configuration will allow csv's to have the header on a line other than the first line of the csv, useful for skipping data not relevant to midpoint. The header row configuration option is expecting an int and defaults to the first row to maintain backward's compatibility.

@1azyman
Copy link
Member

1azyman commented Oct 12, 2017

Thank you for PR.

Before merging this feature, can you please implement at least one test, which will read such csv file and create/update one row there?
I guess that validation should be added for new configuration property as well. What happens if user will put there number < 1? I guess validation should throw configuration exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants