The code compiles, but I haven't checked if it causes any errors. #1
Conversation
Tamago4a
commented
Dec 11, 2024
Tamago4a
commented
- Updated all nugets.
- Updated all events that have changed during this time.
- Ran through the code analyzer and fixed all syntax problems.
- Fixed the problem with incorrect display of the number of players. Now the bot does not take into account NPCs.
This reverts commit fb86e3a.
- Updated all nugets. - Updated all events that have changed during this time. - Ran through the code analyzer and fixed all syntax problems. - Fixed the problem with incorrect display of the number of players. Now the bot does not take into account NPCs.
The code analyzer found this style incorrect, and I agree with it. What is "intend"? |
It's how many spaces you have to put before the code after the construction (it was 4, but you changed it to 2, which is bad) |
I'm afraid you're mistaken. These are not 8 spaces. These are tabs. Try to highlight these "spaces" in your browser and you'll understand. And I repeat, this was done by the code analyzer made by Microsoft developers. I think they are competent enough to know about the correctness of the code style. |
|
The only person who's wrong here is you. Please look at the coding conventions https://learn.microsoft.com/en-us/dotnet/csharp/fundamentals/coding-style/coding-conventions#style-guidelines |
- Updated Nuget Discord.Net
|
Yes, you were right. I was sure that the default settings in visual studio were correct and did not even think about it. However, it turned out that this needs to be done manually in the settings. |
…ds "Available()" but did not implement them. I also updated the code in the method "OnRespawningTeam(RespawningTeamEventArgs ev)". Now everything compiles, but I'm not sure that it will work as expected. In fact, all my commits were made so that it all compiles and runs.
|
I finally tested it and the console window closes instantly. Nothing happens. |
|
|
||
| public override bool Available() | ||
| { | ||
| throw new System.NotImplementedException(); |
There was a problem hiding this comment.
I wrote above that I don’t know how to implement this correctly, since I didn’t create this huge pile of code.
| </Reference> | ||
| <Reference Include="UnityEngine.PhysicsModule"> | ||
| <HintPath>..\..\References\UnityEngine.PhysicsModule.dll</HintPath> |
| </Reference> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Compile Update="Properties\Settings.Designer.cs"> |
There was a problem hiding this comment.
No idea where this came from. But if you delete these lines, the compilation occurs without errors.
