Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making TargetsToAffect a Hashset #123

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

TheLongQuite
Copy link

Description

Describe the changes
Making TargetsToAffect a Hashset instead of List. Using Hashset is more valuable cause there is no case when TargetsToAffect can include not unique elements. Hashset will create a possibility to use Hashset.RemoveWhere that allows us to use predicates. That will make method more flexible.

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@VALERA771
Copy link

Breaking change

@VALERA771 VALERA771 added the Do not merge Don't merge this PR label Oct 1, 2024
VALERA771 pushed a commit to NotZer0Two/OLDEXILED that referenced this pull request Nov 5, 2024
@github-actions github-actions bot removed the Events label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge Don't merge this PR Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants