Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking] AdminToys:Create structure #14

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

louis1706
Copy link

(initial PR) Exiled-Official#118

Problems in old structure

  • it has 2 short-cut lambda methods, and FOUR independent creating methods that simply ctrl c ctrl v with 1 line difference
  • it consists of many Nullable parameters to short argument body, but it result to many ambiguous method calls

What i change

  • add core Create method with all parameters
  • removed all Nullable things
  • add relations between those methods

@github-actions github-actions bot added the API label Jul 31, 2024
@louis1706
Copy link
Author

@IRacle1

@IRacle1
Copy link

IRacle1 commented Aug 1, 2024

👍

@louis1706 louis1706 added the Do not merge Don't merge this PR label Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Do not merge Don't merge this PR Events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants