these are definitely weapons as well

[Mikihero]

Description

Describe the changes

What is the current behavior? Item.IsWeapon only checks for firearms

EXILED/EXILED/Exiled.API/Features/Items/Item.cs

Line 160 in 9cd0e45

public bool IsWeapon => this is Firearm;

What is the new behavior? Checks for Micro HID and jailbird as well as firearm

Does this PR introduce a breaking change? Technically yes, although I can't think of a use case where you wouldn't also want to include other weapons instead of just checking if it's a firearm.

Other information: As it technically is breaking, I was considering just making this a method (ideally a different property tho I culdn't think of a good name, hence a method of a similar name)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentations

Submission checklist

• I have checked the project can be compiled
• I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

• I have checked no IL patching errors in the console

Other

• Still requires more testing

[louis1706]

https://github.com/Mikihero/EXILED/blob/02daca40efaccf6974c7d85a7f5c977fa453e210/EXILED/Exiled.API/Extensions/ItemExtensions.cs#L42
I would use this for check if an item is an weapon this extension permit to check if it's firearm but yeah naming is kinda wrong

[VALERA771]

I wanted to write a joke but I'm too lazy

[louis1706]

in my opinion we should added IsFirearm

and put this one as Obsolete and for Exiled 9 doing this check with all possible Weapon

if you guys thinks it's better to do it directly it's your choice

[Mikihero]

in my opinion we should added IsFirearm

I guess it could be useful for people who have no idea how to cast but the actual code would be just bool IsFirearm => this is Firearm, aka what IsWeapon is rn

[louis1706]

in my opinion we should added IsFirearm

I guess it could be useful for people who have no idea how to cast but the actual code would be just bool IsFirearm => this is Firearm, aka what IsWeapon is rn

that was actually the only use case of this Propperty (they are more if you look under and above this one)

[Mikihero]

in my opinion we should added IsFirearm

I guess it could be useful for people who have no idea how to cast but the actual code would be just bool IsFirearm => this is Firearm, aka what IsWeapon is rn

that was actually the only use case of this Propperty (they are more if you look under and above this one)

not sure what you mean

[louis1706]

in my opinion we should added IsFirearm

I guess it could be useful for people who have no idea how to cast but the actual code would be just bool IsFirearm => this is Firearm, aka what IsWeapon is rn

that was actually the only use case of this Propperty (they are more if you look under and above this one)

not sure what you mean

I mean that it would be good to have a replacement for what they were using until now so we can tell them what to replace IsWeapon with IsFirearm

[Mikihero]

makes sense, I can do that later

[louis1706]

Suggested change

	public bool IsWeapon => this is Firearm || Type is ItemType.Jailbird or ItemType.MicroHID;
	public bool IsWeapon => this is Firearm || Type is ItemType.Jailbird or ItemType.MicroHID;
	/// <summary>
	/// Gets a value indicating whether or not this item is a firearm.
	/// </summary>
	public bool IsFirearm => this is Firearm;