forked from Exiled-Official/EXILED
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clearer documentation on item events #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because you pronounce usable as you-sable, it should be a not an
Mikihero
suggested changes
Nov 22, 2024
fyi the CI failed on getting references, so not my fault :3 |
Mikihero
suggested changes
Nov 22, 2024
@Mikihero done |
💀🙏 |
Mikihero
suggested changes
Nov 22, 2024
Mikihero
reviewed
Nov 22, 2024
Mikihero
approved these changes
Nov 22, 2024
Misaka-ZeroTwo
added
documentation
Improvements or additions to documentation
and removed
Events
labels
Nov 23, 2024
VALERA771
approved these changes
Nov 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK if that's true
@VALERA771 due to nobody else giving any negatives, you can probably merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
@Mikihero and I were discussing what all 3 of the item events do (Using, Used and UsingComplete) and it was confusing what did what, so Miki did some testing and this PR is to include all items that trigger what event and clearer documentation of what each event does exactly, as it currently looks like Used and UsingComplete are the same thing.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other