-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inflow-outflow boundary condition #1066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a first quick pass.
Most of my comments right now are just noting the obvious things to clean up before actually merging. Thank you for taking this task on!! |
Speaking of merging, it looks like there are some complicated merge conflicts between this branch and main. It may be helpful to rebase your branch to upstream/main to remove some of those conflicts and get the unrelated parts of this branch up-to-date. Removing the merge conflicts will also allow the CI tests to run. |
PS. I have been able to rebase this code with the latest changes in the |
3910fe5
to
94a9552
Compare
@asalmgren @marchdf @mbkuhn There are two sticking point: the solution not reaching steady state for my test and the ctest failing (which I can run manually). But I think the code is ready to be reviewed while we debug these. |
I was able to correct the issue that was causing my in-out BC ctest to fail in 5856a85. |
…ls in the same boundary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor code suggestions you can accept. Also, can you add the new BC type to the docs? Around here: https://github.com/Exawind/amr-wind/blob/main/docs/sphinx/user/inputs_Boundary_conditions.rst?plain=1#L12 and then below the existing mass_inflow BC you can add more details.
Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
Head branch was pushed to by a user without write access
--------- Co-authored-by: Marc T. Henry de Frahan <marchdf@gmail.com>
Summary
Enabling the
mass_inflow_outflow
(MIO) BC which allows for both inflow and outflow cells in a boundary.Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
This functionality would be required for coupling with ERF and was started after discussions with @gdeskos and @mchurchf, along with @asalmgren, as it was a desired functionality within AMR-Wind too. Additionally, @hgopalan has expressed interest, and @marchdf has helped along the way.
Description
The changes required can be organized into six categories:
MassInflowOutflowBC.cpp
ext_dir
andfoextrap
behavior respectively.enforceSolvability
routine in AMReX-Hydro before the mac-projection, which adjusts the outflux to match with influx (will link to the corresponding PR in Hydro).input_inout
.