Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check isca python installation is in GFDL_BASE used #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RuthG
Copy link

@RuthG RuthG commented May 15, 2020

Print a warning if the isca python installation used is inconsistent with the GFDL_BASE directory

@sit23
Copy link
Contributor

sit23 commented May 18, 2020

This looks great - thanks Ruth! I wonder if it might be good though to add a little bit more detail to the message as to how this scenario might happen and why it might be a problem? It wouldn’t have to be much, but might help a user sort this problem out.

@RuthG
Copy link
Author

RuthG commented May 18, 2020

Good point! I have added a little more detail, but tried to keep it brief.

Copy link
Contributor

@sit23 sit23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @RuthG - thanks!

@dennissergeev dennissergeev added infrastructure Isca infrastructure: installation, CI, HPC setups priority:medium Medium-piority task python Isca's python wrappers labels May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Isca infrastructure: installation, CI, HPC setups priority:medium Medium-piority task python Isca's python wrappers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants