Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] working version on gfortran11 on macOS v11.2 #211

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaelforget
Copy link

I am opening the PR as a way to share and discuss but shouldnt be merged in its current form

This follows up on #210 and are modifications which eventually allowed me to compile and run held_suarez_test_case.py on a Mac (running OS 11.2).

There were several types of issues as you'll see, some of which I uncovered after upgrading to the latest gfortran compiler (v11)

  • linux system calls which error out on Mac; some I just commented out for now; the affinity part is switched off via a MACOS cpp flag; more or less as done by @jamesp in 2018 (https://github.com/jamesp/Isca/tree/mac)
  • the -fallow-argument-mismatch and -fallow-invalid-boz part is related to warnings that have recently been turned into errors (the options revert to warnings). Would need a switch like in avoid error message introduced in gfortran 10 MITgcm/MITgcm#480 probably for gfortran < v10
  • in create_xgrid.c I needed to add a definition of isHeadNode_b (same as in mosaic_util.c but for the name)
  • added gfortran_mac option file

Maybe this could get reviewed and merged after some revision. Please chime in

@ntlewis
Copy link
Contributor

ntlewis commented Jun 11, 2021

@gaelforget Quick question: do you have an intuition for whether or not the additional changes you've made (i.e., beyond those in Jamie's branch) would affect compilation on Mac setups for which Isca currently does compile (i.e., what Jamie had working)?

@gaelforget
Copy link
Author

@gaelforget Quick question: do you have an intuition for whether or not the additional changes you've made (i.e., beyond those in Jamie's branch) would affect compilation on Mac setups for which Isca currently does compile (i.e., what Jamie had working)?

Except for the -fallow-argument-mismatch and -fallow-invalid-boz part that need to be skipped with gfortran < 10 (see MITgcm/MITgcm#480) I would think so. Would be awesome if you could double check that

@jamesp
Copy link
Contributor

jamesp commented Jun 11, 2021

Great to see progress being made on this @gaelforget, @ntlewis!

@gaelforget how is the performance when you run on mac hardware?

@rosscastle rosscastle added the infrastructure Isca infrastructure: installation, CI, HPC setups label Apr 6, 2022
hdrake referenced this pull request in hdrake/FMS Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Isca infrastructure: installation, CI, HPC setups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants