Finally adding shallow and barotropic models to the Isca master #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…des to Isca. Downloaded necessary files from ftp://ftp.gfdl.noaa.gov/perm/GFDL_pubrelease/Spectral_Idealized_Atmospheric_Models/spectral_idealized_public_release.tar.gz on 14/05/19.
… shallow code base again.
… options in shallow water to get in line with Isca modifications.
…ded same fixes as shallow dynamics.
… it defining grid for output. This should make it possible to use stirring in the shallow water model.
…irring, we can output stirring variables from within shallow water framework.
…ry for compilation of new codes.
…cs and in PV definition, which I previously modified incorrectly.
Conflicts: .gitignore src/extra/python/isca/__init__.py
…t cases. This prevents the code from compiling each time a different trip test is run, thus making the trip tests much faster.
…trip tests. Requires the tests to be more specific about which codebase each test case is using, and also requires a new simple diag table for the 2D cases.
…to be specified from an netcdf input file. As yet untested. Had to add extra fortran files to path-names as the interpolator function uses a lot of other modules.
…ith multiple variables.
… the h term passed in is the perturbation to the mean, and so should have an area mean of zero. This means that the h-0 parameter in the code is what sets the mean depth.
…ostami et al 2017 Saturn hexagon paper.
…, following the rostami et al 2017 paper.
|
All checks have passed, and so I'm going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous p/rs have been submitted for the shallow and barotropic code in #197 and #227, but haven't been closed due to a lack of time for code review. This is the most up to date version of both of these codes, and so this p/r superceeds both of those two. Once testing has completed I'll merge this in.