Radiation changes #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't intend to pass across the `Add T21 spectral resolution to experiment.py' commit, as it has a missing curly brace after the resolution definition. How do I remedy this? |
|
You can commit a fix to the same branch and the PR will pick it up
… On 29 Jun 2018, at 19:20, Neil Lewis ***@***.***> wrote:
I didn't intend to pass across the `Add T21 spectral resolution to experiment.py' commit, as it has a missing curly brace after the resolution definition. How do I remedy this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Issue fixed. I left in the T21 resolution definition, but added the missing brace, as I figured it could be useful to someone at some point. |
|
Great. Yes - definitely a useful addition, thanks for doing that |
jamesp
reviewed
Sep 4, 2018
There was a problem hiding this comment.
Overall looks good.
- There is a core dump that is in the commit? Please delete. How big is this file? If it's huge we might need to scrub it from the history.
- Are the land masks generic, or specific to you? If specific, please remove or document.
- See the inline comments below. I think you have committed a couple of temp files that could do with being removed.
|
@jamesp My apologies for some of the garbage thats ended up in this commit! I'll work through cleaning it up in the next week or two. |
Conflicts: src/extra/python/isca/experiment.py
|
@jamesp I think I've tidied this up now so should be ready to merge 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes are in here:
Multiply insolation in rrtm_radiation and two_stream_gray_rad by rrsun so that non-zero eccentricity has an effect.
Add deallocation for h2o input file interpolation to rrtm_radiation (was missing before).
Add option to prescribe h2o to two_stream_gray_rad from input file using the interpolator.
Add Nakajima 1992 definition of longwave optical depths to two_stream_gray_rad as additional gray radiation scheme option. Ref: https://journals.ametsoc.org/doi/abs/10.1175/1520-0469(1992)049%3C2256:ASOTGE%3E2.0.CO;2.
All additions have been tested.