`[Exiled::Core]` `Assets` and `Fragments` #2568

NaoUnderscore · 2024-05-20T23:22:50Z

Added new classes and attributes for improved entity management.
Added AssetFragment, EClass, EntityAsset, and related attributes.
Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset.
Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets.

- Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets.

VALERA771

Already looks pretty good but little complicated for basic users. I agree that we will need a guide on how to use it.

iamalexrouse · 2024-05-21T14:18:29Z

@NaoUnderscore How test, need examples on scenarios.

Converted `Effect` class to struct.

…ch are not marked as `EClass`.

# Conflicts: # Exiled.API/Features/CustomStats/CustomHealthStat.cs

iamalexrouse · 2024-05-31T16:04:56Z

@Misfiy Hey. Have you done a test and confirmed the PR doesn't produce leaks?

Thanks,
Alex

Misfiy · 2024-05-31T16:33:00Z

Untested. I have only fixed conflicts.

Misfiy · 2024-06-22T21:15:46Z

NOTE: It is do not merge because of possible lag caused by it

iamalexrouse · 2024-06-25T08:21:58Z

Testing now...

iamalexrouse · 2024-06-30T01:42:17Z

@Misfiy @NaoUnderscore

I haven't found any other issues during testing except like 1 null which was fixed, everything should be fine.

* `[Exiled::Core]` `Assets` and `Fragments` (#2568) * Core's assets have been implemented: - Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets. * Implemented `EProperty` for Items * ?. * Minor changes to `EConfig`. Added an `EClass`. Converted `Effect` class to struct. * Added `Generator` `EClass` * Fix hint's `EClass` * Added more `EClass`'es * Fixed `AssetFragment::GenerateAsset` generating assets from types which are not marked as `EClass`. * Fixed `State` compare by ref instead of value * Minor fixes * All `EClass`'es * Fix warnings * Fix docs * Revert CustomHealthStat.cs * Fix build error * fix conflict? * fix typo * fix removals * fix lag & log spam * Changes & null fix * [Core API] Fix null & invalid cast (#2650) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> * Revert "Merge remote-tracking branch 'origin/dev' into apis-rework" This reverts commit 08e279f, reversing changes made to 1b8d3a5. --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com>

* `[Exiled::Core]` `Assets` and `Fragments` (#2568) * Core's assets have been implemented: - Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets. * Implemented `EProperty` for Items * ?. * Minor changes to `EConfig`. Added an `EClass`. Converted `Effect` class to struct. * Added `Generator` `EClass` * Fix hint's `EClass` * Added more `EClass`'es * Fixed `AssetFragment::GenerateAsset` generating assets from types which are not marked as `EClass`. * Fixed `State` compare by ref instead of value * Minor fixes * All `EClass`'es * Fix warnings * Fix docs * Revert CustomHealthStat.cs * Fix build error * fix conflict? * fix typo * fix removals * fix lag & log spam * Changes & null fix * [Core API] Fix null & invalid cast (#2650) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> * Revert "Merge remote-tracking branch 'origin/dev' into apis-rework" This reverts commit 08e279f, reversing changes made to 1b8d3a5. * Exiled9 (#2641) * Changes * that --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com>

* `[Exiled::Core]` `Assets` and `Fragments` (#2568) * Core's assets have been implemented: - Added new classes and attributes for improved entity management. - Added AssetFragment, EClass, EntityAsset, and related attributes. - Any types implementing IAssetFragment can be used to generate a fragment or an EntityAsset. - Began adding EProperty attributes to classes which are supposed to be used to generate fragments and assets. * Implemented `EProperty` for Items * ?. * Minor changes to `EConfig`. Added an `EClass`. Converted `Effect` class to struct. * Added `Generator` `EClass` * Fix hint's `EClass` * Added more `EClass`'es * Fixed `AssetFragment::GenerateAsset` generating assets from types which are not marked as `EClass`. * Fixed `State` compare by ref instead of value * Minor fixes * All `EClass`'es * Fix warnings * Fix docs * Revert CustomHealthStat.cs * Fix build error * fix conflict? * fix typo * fix removals * fix lag & log spam * Changes & null fix * [Core API] Fix null & invalid cast (#2650) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> * Revert "Merge remote-tracking branch 'origin/dev' into apis-rework" This reverts commit 08e279f, reversing changes made to 1b8d3a5. * Exiled9 (#2641) * Changes * that --------- Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> * Moved modified code. (#2656) --------- Co-authored-by: Nameless <85962933+Misfiy@users.noreply.github.com> Co-authored-by: Yamato <66829532+louis1706@users.noreply.github.com> Co-authored-by: Alex Rouse <123724383+ALEXWARELLC@users.noreply.github.com>

NaoUnderscore added enhancement New feature or request regarding-api An issue or PR targeting the Exiled API project requires-testing Things need to be verified by an Exiled Developer/Contributor P1 First Priority labels May 20, 2024

NaoUnderscore added this to the Exiled 9 milestone May 20, 2024

NaoUnderscore requested review from VladTheCow, VALERA771 and Misfiy May 20, 2024 23:22

NaoUnderscore self-assigned this May 20, 2024

NaoUnderscore and others added 5 commits May 21, 2024 01:23

Merge branch 'apis-rework' into deepc-assets

51a2138

Implemented EProperty for Items

97aa95f

?.

e6001a8

Merge remote-tracking branch 'origin/deepc-assets' into deepc-assets

e20b2ba

Merge branch 'apis-rework' into deepc-assets

645953b

VALERA771 approved these changes May 21, 2024

View reviewed changes

Misfiy approved these changes May 21, 2024

View reviewed changes

NaoUnderscore added 10 commits May 23, 2024 15:00

Minor changes to EConfig. Added an EClass.

8f9db00

Converted `Effect` class to struct.

Added Generator EClass

e33bf91

Fix hint's EClass

ff125ee

Added more EClass'es

a264212

Fixed AssetFragment::GenerateAsset generating assets from types whi…

3470fb8

…ch are not marked as `EClass`.

Fixed State compare by ref instead of value

516d66d

Minor fixes

b189719

All EClass'es

dbd83dd

Merge remote-tracking branch 'origin/deepc-assets' into deepc-assets

1a36a8d

Fix warnings

bf513cb

NaoUnderscore marked this pull request as ready for review May 24, 2024 11:44

Misfiy approved these changes May 24, 2024

View reviewed changes

Misfiy added 2 commits May 30, 2024 17:05

fix conflict?

d3b73fa

Merge branch 'apis-rework' into deepc-assets

ad76cea

# Conflicts: # Exiled.API/Features/CustomStats/CustomHealthStat.cs

Misfiy approved these changes May 31, 2024

View reviewed changes

NaoUnderscore and others added 2 commits June 8, 2024 14:28

fix typo

b12f7c9

fix removals

6e453d2

Misfiy added the Do not merge Don't merge this PR label Jun 22, 2024

Merge branch 'apis-rework' into deepc-assets

5cf7854

Merge branch 'apis-rework' into deepc-assets

6e4becf

Misfiy marked this pull request as draft June 24, 2024 11:01

Misfiy added 2 commits June 24, 2024 13:01

Merge branch 'apis-rework' into deepc-assets

3c39520

fix lag & log spam

f239bd5

Misfiy marked this pull request as ready for review June 25, 2024 06:26

Misfiy removed the Do not merge Don't merge this PR label Jun 25, 2024

Changes & null fix

b8e4397

Misfiy added tested This PR has been built and tested and does not cause any obvious errors. documentation Improvements or additions to documentation and removed requires-testing Things need to be verified by an Exiled Developer/Contributor labels Jun 30, 2024

[Core API] Fix null & invalid cast (#2650)

09cd52e

iamalexrouse approved these changes Jun 30, 2024

View reviewed changes

Merge branch 'apis-rework' into deepc-assets

4a42c15

Misfiy added the bug Something isn't working label Jun 30, 2024

NaoUnderscore merged commit 1b8d3a5 into apis-rework Jul 1, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`[Exiled::Core]` `Assets` and `Fragments` #2568

`[Exiled::Core]` `Assets` and `Fragments` #2568

NaoUnderscore commented May 20, 2024

VALERA771 left a comment

iamalexrouse commented May 21, 2024

iamalexrouse commented May 31, 2024

Misfiy commented May 31, 2024

Misfiy commented Jun 22, 2024

iamalexrouse commented Jun 25, 2024

iamalexrouse commented Jun 30, 2024

[Exiled::Core] Assets and Fragments #2568

[Exiled::Core] Assets and Fragments #2568

Conversation

NaoUnderscore commented May 20, 2024

VALERA771 left a comment

Choose a reason for hiding this comment

iamalexrouse commented May 21, 2024

iamalexrouse commented May 31, 2024

Misfiy commented May 31, 2024

Misfiy commented Jun 22, 2024

iamalexrouse commented Jun 25, 2024

iamalexrouse commented Jun 30, 2024

`[Exiled::Core]` `Assets` and `Fragments` #2568

`[Exiled::Core]` `Assets` and `Fragments` #2568