Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review #2764

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Review #2764

wants to merge 19 commits into from

Commits on Aug 7, 2024

  1. Review

    Jean THOMAS authored and warquys committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1841bbb View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    2ca767b View commit details
    Browse the repository at this point in the history
  2. Simplifying Singleton<T> implementation

    The code has been simplified to no longer use a dictionary to manage multiple instances of `Singleton<T>`. Now a single instance of `T` is used via a static `Instance` property.
    
    The `Create` method has been changed to set the instance if it is not already set, and a new `Destroy` method has been added to reset the instance to `null`.
    
    The `TryGet` and `Destroy` methods have been simplified to work with the new single instance implementation.
    
    The calls to `Singleton<VirtualPlugin>.Create(this)` and `Singleton<VirtualPlugin>.Destroy(this)` in `VirtualPlugin.cs` have been commented out, with annotations suggesting that use of the class itself as a singleton might require a different approach to avoid overwriting other instances.
    warquys committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    0c47b98 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    363913a View commit details
    Browse the repository at this point in the history
  2. Review

    Jean THOMAS authored and warquys committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    5e9f65f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b5eb750 View commit details
    Browse the repository at this point in the history
  4. Simplifying Singleton<T> implementation

    The code has been simplified to no longer use a dictionary to manage multiple instances of `Singleton<T>`. Now a single instance of `T` is used via a static `Instance` property.
    
    The `Create` method has been changed to set the instance if it is not already set, and a new `Destroy` method has been added to reset the instance to `null`.
    
    The `TryGet` and `Destroy` methods have been simplified to work with the new single instance implementation.
    
    The calls to `Singleton<VirtualPlugin>.Create(this)` and `Singleton<VirtualPlugin>.Destroy(this)` in `VirtualPlugin.cs` have been commented out, with annotations suggesting that use of the class itself as a singleton might require a different approach to avoid overwriting other instances.
    warquys committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    104c113 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4d736ff View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c3a9dd5 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1e9555c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9e3ef36 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    934754b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4439cfa View commit details
    Browse the repository at this point in the history
  11. Remove IComparable and Rewrite Euqality/Comparaison form UnmanagedEnu…

    …mClass, UniqueUnmagedEnumClass and EnumClass
    
    if a IComparable class i needed the Comparer<ExiledEnumClass>.Default provide one.
    warquys committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    c62918b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c6a7cae View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2024

  1. remove ligne

    warquys committed Sep 22, 2024
    Configuration menu
    Copy the full SHA
    cc01fdf View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Configuration menu
    Copy the full SHA
    1622c67 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f56d761 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1229148 View commit details
    Browse the repository at this point in the history