Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recoded Player.PreAuthenticating wia Patch #2786

Merged
merged 7 commits into from
Oct 28, 2024
Merged

Conversation

Mar1ki
Copy link
Contributor

@Mar1ki Mar1ki commented Oct 23, 2024

Recoded PreAuthenticating event wia patch, so IsAllowed will work.

@github-actions github-actions bot added regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch labels Oct 23, 2024
@Mar1ki Mar1ki requested a review from xNexusACS October 25, 2024 13:29
Copy link
Member

@xNexusACS xNexusACS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix build issues

@Mar1ki Mar1ki requested a review from xNexusACS October 26, 2024 15:11
xNexusACS
xNexusACS previously approved these changes Oct 27, 2024
@NaoUnderscore NaoUnderscore changed the base branch from master to dev October 27, 2024 17:56
@NaoUnderscore NaoUnderscore changed the base branch from dev to master October 27, 2024 17:56
@NaoUnderscore NaoUnderscore dismissed xNexusACS’s stale review October 27, 2024 17:56

The base branch was changed.

@Mar1ki Mar1ki requested a review from xNexusACS October 27, 2024 17:57
@xNexusACS
Copy link
Member

xNexusACS commented Oct 28, 2024

Just some questions I have before merging this, what happens if IsAllowed is set to false? The player auth is rejected and go back to the main menu or the player is stuck in a loop in the loading screen?

Is this also fully tested? All properties returning the correct value, also making sure that this doesn't cause any issue with whitelists, server max slots and reserved slots.

@Mar1ki
Copy link
Contributor Author

Mar1ki commented Oct 28, 2024

When IsAllowed is set to false, player goes back to lobby with Server Not Responding Message. All Values in event args are same with original event. Just tested it on reserved slots and whitelists, it is working and not cousing any troubles with it.

@xNexusACS
Copy link
Member

When IsAllowed is set to false, player goes back to lobby with Server Not Responding Message. All Values in event args are same with original event. Just tested it on reserved slots and whitelists, it is working and not cousing any troubles with it.

nice

@xNexusACS xNexusACS merged commit 3df97bf into Exiled-Team:master Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regarding-events An issue or PR targeting the Exiled Events project regarding-transpiler An issue or PR that touches or is related to a patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants