backfix: add signSchnorr to keychain api #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 2da2b05)
fboucquez
requested review from
kewde,
diegomura and
mvayngrib
as code owners
feri42
approved these changes
Nov 14, 2024
|
we should create a @exodus/keychain@7.4 branch and merge this into that for release, not master |
Done and merged. I can actually call GH publish action from that branch to release this 7.4.1. It's nice, no local release. I guess we are now run out of excuses for local releases; we could harden this in assets |
please do! You might need @sparten11740 's help to set up release environment protection for those branches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backfix of #171 to be added on top of 7.4.0. Later 7.5.x is not ready for production yet
Not to merge, could we manually publish this?