Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keychain)!: remove atom factory #23

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

diegomura
Copy link
Contributor

Removes atom factory from keychain feature package. This now lives in @exodus/keychain-atoms. Reasons explained in https://github.com/ExodusMovement/exodus-hydra/pull/5486 as well:

  • If keychain ends up being extracted to a "wallet process", this makes sense to be extracted so the application side does not need to import keychain (import still required for keys, but that might also be convenient to change)
  • Keychain is the only feature that holds atom factories. We separated fusion ones out of fusion on @exodus/fusion-atoms, so this follows the same pattern
  • All atom factories close to each other

@diegomura diegomura self-assigned this Jan 23, 2024
mvayngrib
mvayngrib previously approved these changes Jan 23, 2024
@diegomura
Copy link
Contributor Author

@mvayngrib CI fails for not found actions. Are you able to merge in the meantime?

mvayngrib
mvayngrib previously approved these changes Jan 24, 2024
@mvayngrib
Copy link
Collaborator

@diegomura please rebase

@diegomura
Copy link
Contributor Author

@mvayngrib done!

@diegomura diegomura force-pushed the dm/remove-keychain-atom-factory branch from 9622181 to 56bcbe3 Compare January 25, 2024 16:25
@mvayngrib mvayngrib merged commit 99570d0 into master Jan 25, 2024
6 of 7 checks passed
@mvayngrib mvayngrib deleted the dm/remove-keychain-atom-factory branch January 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants