fix(jest): support ESM setup files #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChALkeR
reviewed
Oct 5, 2024
tests/setup-files/setup.cjs
Outdated
| @@ -0,0 +1,3 @@ | |||
| const path = require('path') | |||
|
|
|||
| global.SETUP_CJS = path.basename(__filename) // using some cjs stuff here to make sure it works | |||
There was a problem hiding this comment.
globalThis is the canonical name for the global object
global might be not defined in general (e.g. if we support some other env other than Node.js-like)
% jsc
>>> globalThis
[object global]
>>> global
Exception: ReferenceError: Can't find variable: globalThere was a problem hiding this comment.
replaced with globalThis
ChALkeR
reviewed
Oct 5, 2024
tests/setup-files/setup.js
Outdated
| @@ -0,0 +1,3 @@ | |||
| import path from 'path' | |||
|
|
|||
| global.SETUP_JS_MODULE = path.basename(import.meta.url) | |||
There was a problem hiding this comment.
import.meta.url is an url, calling basename on it might be not ideal
does just import.meta.filename work here?
There was a problem hiding this comment.
ah, this is actually testing that import path works, makes sense
There was a problem hiding this comment.
yeah, these 3 setup files are just for testing.
ChALkeR
approved these changes
Oct 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for importing ESM files supplied in jest's
setupFilesorsetupFilesAfterEnv