Enhance Brinkman flow examples and metrics computation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolved a bug in the cylinder placements. - Flow inside cylinder initialized to 0
- Add noise to promote oscillations
This reverts commit f08587a.
…top into example/brinkman_study
gloopydoop
reviewed
Dec 11, 2024
There was a problem hiding this comment.
Wow we actually wrote A LOT for that deliverable!
I guess now this PR needs to be put on hold until I finish the filters in neko, sorry.
I still need to talk to Shiyu to make sure I don't mess up any of his LES stuff but he's in FAU right now, I'll try him on zoom to get things moving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds the examples for Brinkman flow, adds new metrics computation features, and enhances the overall structure and robustness of the code. It includes updates to the generator script, improved error handling, and additional documentation for better usability.
Depends on:
Closes #60