-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#60 Update landing page features #132
#60 Update landing page features #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple minor comments. I'll test the branch for comp matching since the things I mentioned shouldn't impact that much. Be forewarned though, that I'm pretty picky about comp matching, so it's not uncommon for me to have a lot of comments after the first test.
OK, I did more in depth testing of this and here's what I saw. General
Desktop
Mobile
I also tested the way items flow when the screen size changes and that looks good to me. Here are the images I used as reference, taken from the comp and in browser test |
…e-demo into 132-update-landing-page-features
…ocana/ctree-demo into 132-update-landing-page-features
Merging latest changes because they're pretty close, but could still improve the PC browser version. |
For issue #60.
All reviews requested by @CSchmitz81 from #131 have been resolved in this new PR.