Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented basic routing and error checking in the app navigation #33

Merged
merged 10 commits into from
Feb 18, 2018

Conversation

MynahMarie
Copy link
Member

@MynahMarie MynahMarie commented Feb 15, 2018

Relates #12

In this PR I have:

  • implemented routing through the front end of the app
  • made sure users can't navigate the app through the url
  • made sure users need to complete necessary informations before moving on to the next page.

@Karyum
Copy link
Contributor

Karyum commented Feb 18, 2018

@MynahMarie can i review this ? or should i wait for @hoslack ?

@MynahMarie
Copy link
Member Author

@Karyum Please review it... we are now working together so it might take a while for hoslack to be able to review

@Karyum
Copy link
Contributor

Karyum commented Feb 18, 2018

@MynahMarie

Shit conflict

@Karyum Karyum assigned MynahMarie and unassigned Karyum Feb 18, 2018
@MynahMarie
Copy link
Member Author

@Karyum No more conflicts! 😸

Copy link
Contributor

@Karyum Karyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe

Copy link
Contributor

@Karyum Karyum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job

but there must be a better way hmmmm

@Karyum Karyum merged commit 8943ecd into master Feb 18, 2018
@Karyum Karyum deleted the basicRouting branch February 18, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants