Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine makefiles #131

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Refine makefiles #131

merged 4 commits into from
Jan 8, 2024

Conversation

domna
Copy link

@domna domna commented Nov 29, 2023

This adds several things:

  • Proper build of nxdl.xml files even if they are not present. This is now completely based on the available yaml files
  • Removal of nyaml for loop
  • Add a new Makefile nyaml.mk for building nyaml targets to be invoked like this make -f nyaml.mk

@domna domna requested a review from sanbrock November 29, 2023 20:22
Makefile Show resolved Hide resolved
nyaml.mk Outdated Show resolved Hide resolved
@domna
Copy link
Author

domna commented Nov 30, 2023

@sanbrock Everything fixed and should work with make nxdl and make nyaml respectively. This also only builds for updated timestamps and based on the existing yaml and nxdl files. Especially, now new yaml files are also converted to nxdl which was not the case previously

@domna
Copy link
Author

domna commented Jan 4, 2024

@sanbrock I aligned everything with nexusformat#1336

@domna domna requested a review from sanbrock January 4, 2024 07:38
Copy link

@sanbrock sanbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@domna domna merged commit 8516668 into fairmat Jan 8, 2024
6 checks passed
@domna domna deleted the makefile-refinements branch January 8, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants