This commit fixes the duplicate variant issue in the find_subject_dx_… #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implication and find_subject_tx_implication functions. This method of creating a variant list and checcking variant IDs against is okay for now but might have scalability issues. Future implementations should try to limit the variant responses from MongoDB to unique responses.
mihaitodor
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…implication and find_subject_tx_implication functions. This method of creating a variant list and checcking variant IDs against is okay for now but might have scalability issues.
Future implementations should try to limit the variant responses from MongoDB to unique responses.
Description
This commit fixes the issue of duplicate variant issue in the response parameter bundle for find_subject_dx_implication and find_subject_tx_implication functions. This does not have any new requirements.
Fixes # (issue)
How Has This Been Tested?
I tested by running the py tests functions (with the fix implemented) to see the difference in outputted files via working tree differences. I would ctrl-F to find "variant" and check the variant-id. I would then ctrl-f the variant id to ennsure that it only shows up once as a resource id meaning that only one variant resource with that id is present (it is a unique variant resource) . This by extension means that resource ID is okay to show up again when used as a reference as this is not creating a duplicate variant resource just a reference.