Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of qlearning scripts and add pqn #104

Merged
merged 41 commits into from
Jul 12, 2024
Merged

update of qlearning scripts and add pqn #104

merged 41 commits into from
Jul 12, 2024

Conversation

mttga
Copy link
Collaborator

@mttga mttga commented Jul 10, 2024

This is a major update for qlearning baselines which includes:

  • Refactor: Complete refactor of the code, aiming to make it lighter and more readable. Some features are now excluded (such as td_lambda, which follows the PyMARL2 implementation and doesn't seem valid, and non-parameter sharing, which can be easily re-included if needed).
  • Better results: The new code fixes some bugs and adds the possibility to train for multiple epochs per update, resulting in improved sample efficiency and overall performance in Smax (results of the NeurIPS paper).
  • PQN: PQN scripts are included with FF, RNN, and CNN versions. PQN appears to be the state-of-the-art baseline in many JAXMARL environments like Smax, Hanabi, and Overcooked.
  • Overcooked: Scripts with convolutional network and shaped reward are included for PPO, VDN, and PQN-VDN.
  • Additional features: Extra features included in all scripts, such as separate logging of vmapped seeds on wandb, saving of (vampped) parameters after training, and hyperparameter tuning.
  • Configuration alignment: Configuration usage is more aligned with PPO scripts, using a single config YAML file for each script. A general config.yaml is kept to avoid duplicating general hyperparameters like wandb setup in all the configuration files.
  • VDN_FF without RNN: A VDN_FF version without RNN is included.

smax_all_algs_comparison

Copy link
Collaborator

@amacrutherford amacrutherford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mttga mttga merged commit 9b1d643 into main Jul 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants