Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

started a pr about rnn hidsize #56

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

alexunderch
Copy link
Contributor

  1. Fixed the Dockerfile — i.e. added important env. variables and eased development interaction with git;
  2. Changed IPPO baseline for SMAX — i.e. made it independent of rnn hidden_size. Say if the fix actually works and then I can implement it everywhere in IPPO/MAPPO baselines (in configs there is GRU_HIDDEN_SIZE variable (name is arbitrary), with default value of 256). Default experiment is accessible via:
python ippo_rnn_smax.py GRU_HIDDEN_SIZE=128
  1. now WANDB_ENTITY could be parsed directly from the docker environment
  2. A small fix in the walkthrough colab — i.e. a note about runtime reboot after the installation.

If I have to add tests or smth, ping me.

@amacrutherford amacrutherford self-assigned this Jan 25, 2024
@amacrutherford
Copy link
Collaborator

amacrutherford commented Jan 29, 2024

looks great! Have run the RNN change and results look reasonable

@amacrutherford amacrutherford merged commit 0f7ee87 into FLAIROx:main Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants