Merge pull request #217 from Eyantra698Sumanto/sky130-dev

Fixed path_name undefined and out of bound index errors
FOSSEE · Aug 26, 2022 · 076d3b2 · 076d3b2
2 parents 2dbc0fb + 381b96a
commit 076d3b2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/kicadtoNgspice/Convert.py b/src/kicadtoNgspice/Convert.py
@@ -554,7 +554,7 @@ def addDeviceLibrary(self, schematicInfo, kicadFile):
                         print(tempStr)
                         includeLine.append(
                             ".lib \"" + tempStr[0] + "\" " + tempStr[1])
-                        deviceLine[index] = ''
+                        deviceLine[index] = '*scmode'
                         # words.append(completeLibPath)
                         # deviceLine[index] = words
 

diff --git a/src/kicadtoNgspice/DeviceModel.py b/src/kicadtoNgspice/DeviceModel.py
@@ -159,11 +159,13 @@ def eSim_sky130(self, schematicInfo):
         self.entry_var[self.count].setText("")
         self.entry_var[self.count].setMaximumWidth(150)
         self.entry_var[self.count].setObjectName("%d" % beg)
+        path_name = ''
         for child in self.root:
             if child.tag == "scmode1":
                 if child[1].text:
                     self.entry_var[self.count] \
                         .setText(child[1].text)
+                    path_name = child[0].text
                 else:
                     self.entry_var[self.count].setText("")
 
@@ -223,6 +225,7 @@ def eSim_sky130(self, schematicInfo):
                 sky130box.setTitle(
                     "Add parameters for " +
                     words[0] + " : " + words[-1])
+                path_name = ''
 
                 # Adding to get sky130 dimension
                 self.parameterLabel[self.count] = QtWidgets.QLabel(
@@ -251,7 +254,7 @@ def eSim_sky130(self, schematicInfo):
                                 if child[0].text:
                                     self.entry_var[self.count] \
                                         .setText(child[0].text)
-                                    path_name = ""
+                                    path_name = child[0].text
                                 else:
                                     self.entry_var[self.count].setText("")
                                     path_name = ""