Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCMC paper #51

Merged
merged 35 commits into from
Jun 13, 2024
Merged

MCMC paper #51

merged 35 commits into from
Jun 13, 2024

Conversation

JordanHoffmann3
Copy link
Collaborator

No description provided.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

profxj
profxj requested changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing stuff

I've been nit-picky. Hopefully not too annoying...

zdm/MCMC.py Outdated Show resolved Hide resolved
zdm/MCMC.py Outdated Show resolved Hide resolved
zdm/MCMC.py Show resolved Hide resolved
zdm/MCMC.py Show resolved Hide resolved
zdm/MCMC2.py Show resolved Hide resolved
zdm/scripts/test_MCMC2.py Outdated Show resolved Hide resolved
zdm/scripts/test_MCMC2_reps.py Outdated Show resolved Hide resolved
zdm/scripts/test_MCMC2_single.py Outdated Show resolved Hide resolved
zdm/scripts/visualise_mcmc_h5.ipynb Outdated Show resolved Hide resolved
zdm/survey.py Outdated Show resolved Hide resolved
@JordanHoffmann3 JordanHoffmann3 requested a review from profxj June 10, 2024 06:52
cwjames1983
cwjames1983 reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@cwjames1983 cwjames1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge set of updates. Thanks for your comments Profx!

Jordan - never again shall there be an update so large in one chunk. Let's make sure we do this in much smaller efforts. But amazing work!

profxj
profxj approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@profxj profxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge!

@profxj profxj merged commit 691baed into main Jun 13, 2024
6 checks passed
@profxj profxj deleted the MCMCreps branch June 13, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwjames1983 cwjames1983 cwjames1983 left review comments

@profxj profxj profxj approved these changes

Assignees

@JordanHoffmann3 JordanHoffmann3

@cwjames1983 cwjames1983

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JordanHoffmann3 @profxj @cwjames1983