Skip to content

Commit

Permalink
Remove if around revisionHistoryLimit (#1367)
Browse files Browse the repository at this point in the history
Setting this to 0 prevents anything being templated as 0 is considered false.

Co-authored-by: Andy Suderman <andy@fairwinds.com>
  • Loading branch information
bodgit and sudermanjr authored Jan 17, 2024
1 parent ce9ea5f commit 489a211
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 7 deletions.
2 changes: 1 addition & 1 deletion stable/vpa/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: vpa
description: A Helm chart for Kubernetes Vertical Pod Autoscaler
type: application
version: 4.4.0
version: 4.4.1
appVersion: 1.0.0
maintainers:
- name: sudermanjr
Expand Down
2 changes: 0 additions & 2 deletions stable/vpa/templates/admission-controller-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ metadata:
{{- include "vpa.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.admissionController.replicaCount }}
{{- if .Values.admissionController.revisionHistoryLimit }}
revisionHistoryLimit: {{ .Values.admissionController.revisionHistoryLimit }}
{{- end }}
selector:
matchLabels:
app.kubernetes.io/component: admission-controller
Expand Down
2 changes: 0 additions & 2 deletions stable/vpa/templates/recommender-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ metadata:
{{- include "vpa.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.recommender.replicaCount }}
{{- if .Values.recommender.revisionHistoryLimit }}
revisionHistoryLimit: {{ .Values.recommender.revisionHistoryLimit }}
{{- end }}
selector:
matchLabels:
app.kubernetes.io/component: recommender
Expand Down
2 changes: 0 additions & 2 deletions stable/vpa/templates/updater-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ metadata:
{{- include "vpa.labels" . | nindent 4 }}
spec:
replicas: {{ .Values.updater.replicaCount }}
{{- if .Values.updater.revisionHistoryLimit }}
revisionHistoryLimit: {{ .Values.updater.revisionHistoryLimit }}
{{- end }}
selector:
matchLabels:
app.kubernetes.io/component: updater
Expand Down

0 comments on commit 489a211

Please sign in to comment.