Skip to content

Commit

Permalink
[stable/goldilocks] Monitoring all namespaces out of the box (#1509)
Browse files Browse the repository at this point in the history
* Monitoring all namespaces by default

It was not well mentioned within the documentation.

* Updated chart version

Updated chart version

* No multi line comments

* Update Chart.yaml

* Apply suggestions from code review

* Update README.md  for goldilocks chart

added  "on-by-default" flag

* docs: run helm-docs

---------

Co-authored-by: Vitor Rodrigo Vezani <vitor.vezani@fairwinds.com>
Co-authored-by: Andy Suderman <andy@fairwinds.com>
Co-authored-by: Andy Suderman <andy@suderman.dev>
  • Loading branch information
4 people authored Oct 1, 2024
1 parent 8033729 commit c29beaf
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion stable/goldilocks/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
appVersion: "v4.13.0"
version: 9.0.0
version: 9.0.1
kubeVersion: ">= 1.22.0-0"
description: |
A Helm chart for running Fairwinds Goldilocks. See https://github.com/FairwindsOps/goldilocks
Expand Down
4 changes: 2 additions & 2 deletions stable/goldilocks/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ This will completely remove the VPA and then re-install it using the new method.
| controller.rbac.extraClusterRoleBindings | list | `[]` | A list of ClusterRoles for which ClusterRoleBindings will be created for the ServiceAccount, if enabled |
| controller.serviceAccount.create | bool | `true` | If true, a service account will be created for the controller. If set to false, you must set `controller.serviceAccount.name` |
| controller.serviceAccount.name | string | `nil` | The name of an existing service account to use for the controller. Combined with `controller.serviceAccount.create` |
| controller.flags | object | `{}` | A map of additional flags to pass to the controller |
| controller.flags | object | `{}` | A map of additional flags to pass to the controller. For monitoring all namespaces out of the box, add the following flag "on-by-default: true" |
| controller.logVerbosity | string | `"2"` | Controller log verbosity. Can be set from 1-10 with 10 being extremely verbose |
| controller.nodeSelector | object | `{}` | Node selector for the controller pod |
| controller.tolerations | list | `[]` | Tolerations for the controller pod |
Expand All @@ -99,7 +99,7 @@ This will completely remove the VPA and then re-install it using the new method.
| dashboard.service.type | string | `"ClusterIP"` | The type of the dashboard service |
| dashboard.service.port | int | `80` | The port to run the dashboard service on |
| dashboard.service.annotations | object | `{}` | Extra annotations for the dashboard service |
| dashboard.flags | object | `{}` | A map of additional flags to pass to the dashboard |
| dashboard.flags | object | `{}` | A map of additional flags to pass to the dashboard. For monitoring all namespaces out of the box, add the following flag "on-by-default: true". |
| dashboard.logVerbosity | string | `"2"` | Dashboard log verbosity. Can be set from 1-10 with 10 being extremely verbose |
| dashboard.excludeContainers | string | `"linkerd-proxy,istio-proxy"` | Container names to exclude from displaying in the Goldilocks dashboard |
| dashboard.rbac.create | bool | `true` | If set to true, rbac resources will be created for the dashboard |
Expand Down
5 changes: 2 additions & 3 deletions stable/goldilocks/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ controller:
create: true
# controller.serviceAccount.name -- The name of an existing service account to use for the controller. Combined with `controller.serviceAccount.create`
name:

# controller.flags -- A map of additional flags to pass to the controller
# controller.flags -- A map of additional flags to pass to the controller. For monitoring all namespaces out of the box, add the following flag "on-by-default: true"
flags: {}
# controller.logVerbosity -- Controller log verbosity. Can be set from 1-10 with 10 being extremely verbose
logVerbosity: "2"
Expand Down Expand Up @@ -108,7 +107,7 @@ dashboard:
port: 80
# dashboard.service.annotations -- Extra annotations for the dashboard service
annotations: {}
# dashboard.flags -- A map of additional flags to pass to the dashboard
# dashboard.flags -- A map of additional flags to pass to the dashboard. For monitoring all namespaces out of the box, add the following flag "on-by-default: true".
flags: {}
# dashboard.logVerbosity -- Dashboard log verbosity. Can be set from 1-10 with 10 being extremely verbose
logVerbosity: "2"
Expand Down

0 comments on commit c29beaf

Please sign in to comment.