Fixing title on changing timeline preference

Fixing empty timeline on single entry with disabled dots
Faltenreich · Apr 2, 2022 · 96c24c9 · 96c24c9
1 parent f68c669
commit 96c24c9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/app/src/main/java/com/faltenreich/diaguard/feature/timeline/TimelineFragment.java b/app/src/main/java/com/faltenreich/diaguard/feature/timeline/TimelineFragment.java
@@ -215,6 +215,6 @@ public void onEvent(CategoryPreferenceChangedEvent event) {
 
     @Subscribe(threadMode = ThreadMode.MAIN)
     public void onEvent(TimelinePreferenceChangedEvent event) {
-        goToDay(day);
+        adapter.reset();
     }
 }
diff --git a/app/src/main/java/com/faltenreich/diaguard/feature/timeline/chart/DayChartData.java b/app/src/main/java/com/faltenreich/diaguard/feature/timeline/chart/DayChartData.java
@@ -143,15 +143,6 @@ private IScatterDataSet getScatterDataSet(DataSetType type) {
         return dataSet;
     }
 
-    private void addEntry(Entry entry, DataSetType type) {
-        if (showLines) {
-            getLineDataSet().addEntry(entry);
-        }
-        if (showDots) {
-            getScatterDataSet(type).addEntry(entry);
-        }
-    }
-
     private void addEntry(Entry entry) {
         float yValue = entry.getY();
         if (PreferenceStore.getInstance().limitsAreHighlighted()) {
@@ -166,4 +157,14 @@ private void addEntry(Entry entry) {
             addEntry(entry, DataSetType.TARGET);
         }
     }
+
+    private void addEntry(Entry entry, DataSetType type) {
+        if (showLines) {
+            getLineDataSet().addEntry(entry);
+        }
+        // Show dot anyway if there is only one entry since it will not be connected with a line
+        if (values.size() == 1 || showDots) {
+            getScatterDataSet(type).addEntry(entry);
+        }
+    }
 }