Refactor defer-close with error handling #378
Open
+324
−201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to https://github.com/Fantom-foundation/sonic-admin/issues/90
This PR adds real life use cases of both functions provided the caution package to properly handler errors in case of
defer
andclose
.This PR fixes some of the unhandled errors reported by the external audit. Most (if not all) of them are from either
defer close
patterns or similar cleanups or unhandled close errors.Test list to verify we don't have double closes (or other errors) and panic now because error is no longer ignored:
make test