Add integration tests for sonictool. #381
Open
+623
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of https://github.com/Fantom-foundation/sonic-admin/issues/90
During the changes introduced to capture and handle every error in the codebase,
sonictool
is modified with new error paths; caused by error handling from previously ignored errors.This PR adds automated testing for the
sonictool
subcommands, checking that execution of such is not compromised by the introduction of new error checks.This PR introduces two changes outside of the test:
sonictool
uses nowUserPrompt
for all terminal input, to facilitate testing. A proxy re-export of ethereum'sUserPrompt
is introduced to enable stdin redirect and mocking.sonictool
execution is now closed. Otherwise, tests introduced cannot reuse database within the same process.sonictool heal
command in a reasonable execution time.