Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a verbose parameter to disable the warning messages in the console #38

Merged

Conversation

AxiomeCG
Copy link

@AxiomeCG AxiomeCG commented May 31, 2023

I suggested a verbose parameter sometime ago, I had some time today, so I made it myself.

I preserved the default behaviour of warning, so it is working as before. But we have now the possibility to disable the warnings, if it is polluting.

Resolves #37

@FarazzShaikh
Copy link
Owner

Thanks for the PR! I would like for this option to be true by default. So perhaps we can rename it it “silent” that if set will disable the messages

this way we can avoid confusion from first time users who might interpret this behavior as s bug

We can also set it so that if in a production environment “silent” will be set by default

@AxiomeCG
Copy link
Author

AxiomeCG commented Jun 1, 2023

I thought I made sure that the boolean is set to true by default for verbose. 😀

Just to confirm with you, if we put silent, then making it false by default should be the way to go so the default behaviour is the same (showing the warnings by default and being able to silent them)

@FarazzShaikh
Copy link
Owner

FarazzShaikh commented Jun 1, 2023

Yes that is correct. Silent will false or undefined by default.

Also please describe the option in the readme

@AxiomeCG
Copy link
Author

AxiomeCG commented Jun 1, 2023

Roger that, I will make the update asap, thank you for the feedback !

@FarazzShaikh
Copy link
Owner

Of course! I appreciate the PR!

@AxiomeCG
Copy link
Author

AxiomeCG commented Jun 1, 2023

It should do the trick, I added a bit of documentation in the examples. Tell me if there is some of the things to change !

@FarazzShaikh
Copy link
Owner

Great thanks! I’m currently out on vacation, I will take a look at this as soon as I’m back in business.

@FarazzShaikh FarazzShaikh merged commit e74f98d into FarazzShaikh:main Jun 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Function copy already exists on CSM, renaming to base_copy
2 participants