-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: evolve worker distribution strategy #449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeesch
requested review from
ailtonguitar,
joelfoliveira,
gsferreira,
simaoribeiro,
brmagadutra and
ruiqbarbosa
October 10, 2023 09:42
gsferreira
reviewed
Oct 10, 2023
filipeesch
force-pushed
the
release/3.0
branch
from
October 23, 2023 12:05
87cd205
to
d5a9c21
Compare
filipeesch
force-pushed
the
worker-distribution-strategy
branch
from
October 25, 2023 10:28
11f89dc
to
44f835f
Compare
simaoribeiro
approved these changes
Oct 25, 2023
JoaoRodriguesGithub
approved these changes
Oct 25, 2023
erik-catalao
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ruiqbarbosa
approved these changes
Oct 25, 2023
joelfoliveira
approved these changes
Oct 30, 2023
src/KafkaFlow.Abstractions/Configuration/IConsumerConfigurationBuilder.cs
Outdated
Show resolved
Hide resolved
brmagadutra
approved these changes
Oct 30, 2023
filipeesch
force-pushed
the
worker-distribution-strategy
branch
from
October 31, 2023 12:36
44f835f
to
f56d8e2
Compare
src/KafkaFlow.Abstractions/Configuration/IConsumerConfigurationBuilder.cs
Outdated
Show resolved
Hide resolved
joelfoliveira
force-pushed
the
worker-distribution-strategy
branch
from
November 17, 2023 11:34
f56d8e2
to
f0eb873
Compare
joelfoliveira
force-pushed
the
worker-distribution-strategy
branch
from
November 17, 2023 11:45
f0eb873
to
96f5c49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change addresses the need for a more versatile mechanism for distributing workers based on specific message and consumer details. A new class WorkerDistributionStrategyContext was introduced to encapsulate these details.
Fixes #448 #440
How Has This Been Tested?
Manually and executing the automated tests
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement