Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inc and Dec gauge metrics #27

Merged
merged 1 commit into from
May 14, 2024

Conversation

tiagodaraujo
Copy link
Contributor

Description

The Prometheus documentation suggests using the Inc and Dec method for a queue problem as we have here.

As I mentioned in #22, it is possible to replicate using only unit tests.

This commit changes the use of gauge.Set to gauge.Inc and gauge.Dec in the queue and concurrency events.

Fixes #22

How Has This Been Tested?

Run the integration tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@brmagadutra brmagadutra changed the base branch from main to 1.0.2-beta May 14, 2024 14:32
@brmagadutra brmagadutra merged commit 2b98fb5 into Farfetch:1.0.2-beta May 14, 2024
2 checks passed
@joelfoliveira joelfoliveira mentioned this pull request May 15, 2024
4 tasks
Copy link

@RXFB RXFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: http_requests_queue_items_total is not zero after process entire queue
7 participants