Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4620: check default Creator before implicitly named #4622

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix #4620: check default Creator before implicitly named #4622

merged 2 commits into from
Jul 17, 2024

Conversation

cowtowncoder
Copy link
Member

Simple fix by re-ordering; we'll see if that is sufficient to resolve issues.

@cowtowncoder
Copy link
Member Author

Ok, not quite: looks like there is an expectation that "@JsonProperty-explicit" Creator should be used instead of Record canonical constructor. So need to change implementation slightly.

@cowtowncoder cowtowncoder merged commit 7e59a33 into 2.18 Jul 17, 2024
9 checks passed
@cowtowncoder cowtowncoder deleted the tatu/2.18/4620-default-ctor-over-implicits branch July 17, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cowtowncoder