Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jackson-3] Address #493, disable DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES by default. #4625

Merged
merged 3 commits into from
Jul 20, 2024

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Jul 19, 2024

addresses #493

Note

Once merged, JStep-2 Wiki should be updated.

@JooHyukKim JooHyukKim changed the base branch from 2.18 to master July 19, 2024 14:16
@cowtowncoder
Copy link
Member

@JooHyukKim Looks good, only had 1 comment that I added. I can change that & update release notes and then merge this.

@cowtowncoder cowtowncoder merged commit a019f63 into FasterXML:master Jul 20, 2024
6 checks passed
@cowtowncoder
Copy link
Member

Merged. Thank you @JooHyukKim !

@cowtowncoder
Copy link
Member

@JooHyukKim Could you update JSTEP-2 page with change? I updated README, release-notes wiki.

@JooHyukKim
Copy link
Member Author

JooHyukKim commented Jul 21, 2024

@JooHyukKim Could you update JSTEP-2 page with change? I updated README, release-notes wiki.

Yes, for sure 👍🏼

Done 👍🏼

@JooHyukKim JooHyukKim deleted the fix-493 branch July 21, 2024 14:47
@cowtowncoder
Copy link
Member

cowtowncoder commented Jul 25, 2024

@JooHyukKim I think this broke a few tests in downstream packages (dataformats (binary, text, xml), jackson-modules-base etc). The reason it was not obvious was because snapshot builds started failing for 3.x few weeks ago -- I think api token I used got disabled for some reason. I created new one, assigned as secret, and snapshot deploys work again... and now breakage is obvious.

F.ex:

@cowtowncoder
Copy link
Member

Fixed jackson-modules-base (2 tests for Afterburner, Blackbird, copied from jackson-databind).

Failing:

(and possibly others but these at least)

@JooHyukKim
Copy link
Member Author

JooHyukKim commented Jul 25, 2024

Oh okay, thanks! Will try to check on others as well

@JooHyukKim
Copy link
Member Author

I wonder there is a way to alert cascading-build failure back to databind 🤔
Or if it should/shouldn't

@cowtowncoder
Copy link
Member

@JooHyukKim in theory, there probably would be a way (cascading rebuild case could take some action). But for now email notifications probably need to suffice, as long as they get triggered. Although the problem here was not cascading part but snapshot deploy: both since new snapshot version was not made available and since this prevent cascading builds themselves (but without snapshot deploy they wouldn't have found issues either).

@cowtowncoder
Copy link
Member

Ok so XML and text-formats fixed. Aside from binary-formats, Scala, 2 more failures:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants