-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extension jackson-jr-extension-javatime
to support (some) Java 8 date/time types
#111
Conversation
Quick note: I fixed issue with CI failures (a regression in jackson-core), so now all tests pass as expected. |
First of all: thank you for contributing this, @Shounaks !
(see examples of f.ex jr-annotation-support/) Aside from that, one thing we need is CLA, from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and it only needs to be sent once before the first contribution. Usually it's easiest to print, fill & sign, scan/photo, email to Thank you again; I am looking forward to getting this merged for inclusion in 2.17.0 release! |
Ok, one more thing: I think main I will also remove JDK 20 references; package is still JDK 8 compatible for Jackson 2.x |
Looks good; if we can get CLA sorted out I think I should be able to merge this! |
Sure, the idea of configurability sounds reasonable. One thing I would suggest, however, is to not call formatter DEFAULT_FORMATTER and assume it is used for everything, since if and when adding new types they will need different formatters. So I would probably add separate setter method for configuring .... actually, I only now realize that the provider probably should be renamed too, not to be just for |
...src/main/java/com/fasterxml/jackson/jr/extension/datetime/JacksonLocalDateTimeExtension.java
Outdated
Show resolved
Hide resolved
…g extension for all Java 8 DateTypes.
jackson-jr-extension-javatime
to support (some) Java 8 date/time types
First of all: thank you @Shounaks for contributing this! It will be in Jackson 2.17.0 rc1 to be released soon. One thing: I Merged before remembering to ask or one thing -- basic set of unit tests would be nice, if possible (via different PR)? |
Sorry about previous tries, I believe this might suffice.
Regarding Issue #100