Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soujuurou/Charlotte #1811

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Soujuurou/Charlotte #1811

wants to merge 14 commits into from

Conversation

ArthurKun21
Copy link
Collaborator

@ArthurKun21 ArthurKun21 commented May 1, 2024

Soujuurou

output_720p


Updated to use [ and ] to signify the Special command

[TCh1] -> Choice 1 of 3

[TCh2] -> Choice 2 of 3

[TCh3] -> Choice 3 of 3


All new Special Target have special condition that one of the commands must not look like the starting string for another code

For Example

[TCh1] -> Choice 1 of 3

There should be no [TCh] command, as having so will create problems when parsing. Already added checker on the code that will throw an error when run on device.


Updated the error message when manually entering skill command for more clarity

image


fixes #1841

@ArthurKun21
Copy link
Collaborator Author

This script is working, we just need to discuss something about the commands to be laid out.

@ArthurKun21 ArthurKun21 marked this pull request as draft May 11, 2024 09:30
@ArthurKun21 ArthurKun21 added the PR: Awaiting Team consensus For a functionally complete PR whose implementation is still under discussion or expected to change. label May 11, 2024
@vybze
Copy link
Collaborator

vybze commented May 14, 2024

I was thinking about replacing Emiya with Command Card Change (CCC) and then adding options for the different servants within this option

@vybze vybze marked this pull request as ready for review May 14, 2024 02:21
@ArthurKun21 ArthurKun21 marked this pull request as draft May 14, 2024 07:05
@oppaio

This comment has been minimized.

@ArthurKun21 ArthurKun21 force-pushed the soujuurou branch 2 times, most recently from 6d3a4b0 to e22595b Compare May 31, 2024 05:40
@ArthurKun21 ArthurKun21 marked this pull request as ready for review June 5, 2024 07:45
@ArthurKun21
Copy link
Collaborator Author

PR is now ready for more testing.

@ArthurKun21 ArthurKun21 removed the PR: Awaiting Team consensus For a functionally complete PR whose implementation is still under discussion or expected to change. label Jun 10, 2024
@ArthurKun21
Copy link
Collaborator Author

ArthurKun21 commented Jun 10, 2024

Might be good idea to start migrating other special commands too

Kukulcan

  • don't use crit stars [KULNCS]
  • use crit stars [KULCS]

Transform

  • Transform once (melusine) [TRF1]
  • Transform every time (Ptolemy) [TRF2]

But let the old code stay here for backwards compatibility, but any new codes would use the new format

or probably in a new PR after this get merged.

@ArthurKun21 ArthurKun21 marked this pull request as draft August 9, 2024 10:49
@ArthurKun21
Copy link
Collaborator Author

Going to rename the function thanks to Charlotte's new skill

@vybze
Copy link
Collaborator

vybze commented Aug 9, 2024

Screenshot_20240809-115638
Posting this here for reference

@ArthurKun21 ArthurKun21 changed the title Soujuurou Soujuurou/Charlotte Aug 19, 2024
@ArthurKun21 ArthurKun21 marked this pull request as ready for review August 19, 2024 05:22
@ArthurKun21 ArthurKun21 linked an issue Aug 19, 2024 that may be closed by this pull request
1 task
@vybze
Copy link
Collaborator

vybze commented Sep 12, 2024

And another one for the list
Untitled
Will add a better screenshot at a later date

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add sanjuurou 3ºskill options Shizuki Soujyuro's skill 3 can't be used
3 participants